> On Feb. 11, 2013, 9:21 p.m., ilya musayev wrote: > > vmware-base/test/com/cloud/vmware/TestVMWare.java, line 1001 > > <https://reviews.apache.org/r/9201/diff/1/?file=254272#file254272line1001> > > > > Do we have to be bound to a static dvSwitch0 or can this be retrieved > > dynamically?
This class runs functional test only, and takes dvswitch name as parameter now. > On Feb. 11, 2013, 9:21 p.m., ilya musayev wrote: > > vmware-base/test/com/cloud/vmware/TestVMWare.java, line 1002 > > <https://reviews.apache.org/r/9201/diff/1/?file=254272#file254272line1002> > > > > static entry, please confirm.. This is added as command line parameter now. > On Feb. 11, 2013, 9:21 p.m., ilya musayev wrote: > > vmware-base/test/com/cloud/vmware/TestVMWare.java, line 1006 > > <https://reviews.apache.org/r/9201/diff/1/?file=254272#file254272line1006> > > > > ports set to 64 - maybe to little unless its for the test, please > > confirm Yes this is just for test. We have global configuration parameter vmware.ports.per.dvportgroup to configure the number of dvports per dvportgroup created by CloudStack. By default the number of dvports is configured as 256. Thanks. - Sateesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9201/#review16443 ----------------------------------------------------------- On Feb. 13, 2013, 4:04 a.m., Sateesh Chodapuneedi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9201/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2013, 4:04 a.m.) > > > Review request for cloudstack, Murali Reddy and Kelven Yang. > > > Description > ------- > > This is 4th patch for feature 'Support for VMware dvSwitch in CloudStack'. > This patch contains, test cases and changes to prepareNetwork function to > consider vmware dvswitch as well. Trying to create new dv port group if not > alreayd present and update in case of modification of dvportgroup shaping > policy. > > > This addresses bug CLOUDSTACK-657. > > > Diffs > ----- > > vmware-base/test/com/cloud/vmware/TestVMWare.java 43c784c > > Diff: https://reviews.apache.org/r/9201/diff/ > > > Testing > ------- > > Manual testing:- > 1) Tested guest traffic over dvSwitch on a dedicated physical network. In > this case management and public traffic uses standard vSwitch on a common > physical network. > 2) Tested both guest traffic and public traffic over dvSwitch on a physical > network. > 3) Use optional parameters added to AddClusterCmd to override Zone level > network traffic label. Tested 2 clusters, one with standard vSwitch and other > with dvSwitch. > 4) Tested all 3 traffic types on single physical network with global > parameter 'vmware.use.dvswitch' set to false. This is default configuration > scenario. > > > Added following tests, > 1) Test fetching dvSwitch object from vCenter > 2) Test for presence of dvPortGroup > 3) Test presence of dvPortGroup > 4) Test get existing dvPortGroup > 5) fetch dvPortGroup configuration > 6) Test compare dvPortGroup configuration > 7) Test update dvPortGroup configuration > > > Thanks, > > Sateesh Chodapuneedi > >
