You should upload the entire patch instead of the delta. Reviewboard already has the option of viewing diff between 2 revisions
From: Sateesh Chodapuneedi [mailto:nore...@reviews.apache.org] On Behalf Of Sateesh Chodapuneedi Sent: Monday, February 18, 2013 10:17 AM To: Murali Reddy; Kelven Yang Cc: Sateesh Chodapuneedi; cloudstack; Koushik Das Subject: Re: Review Request: PATCH-4 for feature VMware vNetwork Distributed Virtual Switch support in CloudStack This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9201/ On February 17th, 2013, 2:01 p.m., Koushik Das wrote: I can only see the test cases. Where is the changes related to prepareNetwork as you have mentioned in the description? Revision 1 contains those changes Link - https://reviews.apache.org/r/9201/diff/1/#index_header) Revision 2 contains only changes to TestVmware.java files to update test cases to take test data as parameters. PrepareNetwork changes are in HypervisorHostHelper.java in revision 1. No changes has been done in this file for revision #2. Thanks. - Sateesh On February 13th, 2013, 4:04 a.m., Sateesh Chodapuneedi wrote: Review request for cloudstack, Murali Reddy and Kelven Yang. By Sateesh Chodapuneedi. Updated Feb. 13, 2013, 4:04 a.m. Description This is 4th patch for feature 'Support for VMware dvSwitch in CloudStack'. This patch contains, test cases and changes to prepareNetwork function to consider vmware dvswitch as well. Trying to create new dv port group if not alreayd present and update in case of modification of dvportgroup shaping policy. Testing Manual testing:- 1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network. 2) Tested both guest traffic and public traffic over dvSwitch on a physical network. 3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch. 4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario. Added following tests, 1) Test fetching dvSwitch object from vCenter 2) Test for presence of dvPortGroup 3) Test presence of dvPortGroup 4) Test get existing dvPortGroup 5) fetch dvPortGroup configuration 6) Test compare dvPortGroup configuration 7) Test update dvPortGroup configuration Bugs: CLOUDSTACK-657 Diffs * vmware-base/test/com/cloud/vmware/TestVMWare.java (43c784c) View Diff<https://reviews.apache.org/r/9201/diff/>
