----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9201/#review16923 -----------------------------------------------------------
Ship it! Ship It! - Kelven Yang On Feb. 19, 2013, 6:41 a.m., Sateesh Chodapuneedi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9201/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2013, 6:41 a.m.) > > > Review request for cloudstack, Murali Reddy and Kelven Yang. > > > Description > ------- > > This is 4th patch for feature 'Support for VMware dvSwitch in CloudStack'. > This patch contains, test cases and changes to prepareNetwork function to > consider vmware dvswitch as well. Trying to create new dv port group if not > alreayd present and update in case of modification of dvportgroup shaping > policy. > > > This addresses bug CLOUDSTACK-657. > > > Diffs > ----- > > vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java > 50f9541 > vmware-base/test/com/cloud/vmware/TestVMWare.java 43c784c > > Diff: https://reviews.apache.org/r/9201/diff/ > > > Testing > ------- > > Manual testing:- > 1) Tested guest traffic over dvSwitch on a dedicated physical network. In > this case management and public traffic uses standard vSwitch on a common > physical network. > 2) Tested both guest traffic and public traffic over dvSwitch on a physical > network. > 3) Use optional parameters added to AddClusterCmd to override Zone level > network traffic label. Tested 2 clusters, one with standard vSwitch and other > with dvSwitch. > 4) Tested all 3 traffic types on single physical network with global > parameter 'vmware.use.dvswitch' set to false. This is default configuration > scenario. > > > Added following tests, > 1) Test fetching dvSwitch object from vCenter > 2) Test for presence of dvPortGroup > 3) Test presence of dvPortGroup > 4) Test get existing dvPortGroup > 5) fetch dvPortGroup configuration > 6) Test compare dvPortGroup configuration > 7) Test update dvPortGroup configuration > > > Thanks, > > Sateesh Chodapuneedi > >
