----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7660/#review16634 -----------------------------------------------------------
This gives the ability to the user to affect other user vms as well, which is not desirable. I would suggest you to do the following. When you delete iso, mark it removed in DB so that its not available for further use. In the storage cleanup thread check whether the iso is detached for the vms and if it is then delete it from the sec. storage. - Nitin Mehta On Feb. 15, 2013, 5:02 a.m., deepti dohare wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7660/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2013, 5:02 a.m.) > > > Review request for cloudstack. > > > Description > ------- > > Currently no warning or confirmation is given or required to delete an iso > which is attached to a virtual machine. > > Fixing this issue using “force” delete option. > If an admin or a user deletes an ISO which is attached to a vm: > 1. Without force option; gives a warning that ISO is attached to vm “Failed > to delete iso. It is currently attached to virtual machine. Please detach it > before deleting”. > 2. With force option: first detach the ISO from all vms and then deletes the > ISO. > > > This addresses bug CLOUDSTACK-357. > > > Diffs > ----- > > api/src/org/apache/cloudstack/api/command/user/iso/DeleteIsoCmd.java > c821775 > server/src/com/cloud/template/TemplateManagerImpl.java f9cf277 > server/src/com/cloud/vm/dao/UserVmDao.java 9fbcde3 > server/src/com/cloud/vm/dao/UserVmDaoImpl.java f2fc10b > ui/scripts/templates.js 040ce4a > > Diff: https://reviews.apache.org/r/7660/diff/ > > > Testing > ------- > > Verified locally. Tested for some cases: > > 1. Deleting iso(not attached to any vm) > 2. Deleting iso(attached to multiple vms in same domain) > 3. Deleting iso(attached to multiple vms in different domains) > > For admin/user > > > Thanks, > > deepti dohare > >
