----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7660/ -----------------------------------------------------------
(Updated Feb. 18, 2013, 1:59 p.m.) Review request for cloudstack and Min Chen. Changes ------- Updated the patch with the suggested changes. Description ------- Currently no warning or confirmation is given or required to delete an iso which is attached to a virtual machine. Fixing this issue using “force” delete option. If an admin or a user deletes an ISO which is attached to a vm: 1. Without force option; gives a warning that ISO is attached to vm “Failed to delete iso. It is currently attached to virtual machine. Please detach it before deleting”. 2. With force option: first detach the ISO from all vms and then deletes the ISO. This addresses bug CLOUDSTACK-357. Diffs (updated) ----- api/src/org/apache/cloudstack/api/command/user/iso/DeleteIsoCmd.java c821775 server/src/com/cloud/template/TemplateManagerImpl.java f9cf277 server/src/com/cloud/vm/dao/UserVmDao.java 9fbcde3 server/src/com/cloud/vm/dao/UserVmDaoImpl.java f2fc10b ui/scripts/templates.js 040ce4a Diff: https://reviews.apache.org/r/7660/diff/ Testing ------- Verified locally. Tested for some cases: 1. Deleting iso(not attached to any vm) 2. Deleting iso(attached to multiple vms in same domain) 3. Deleting iso(attached to multiple vms in different domains) For admin/user Thanks, deepti dohare
