----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7660/ -----------------------------------------------------------
(Updated Feb. 19, 2013, 5:21 p.m.) Review request for cloudstack and Min Chen. Changes ------- Thanks for the review comments Nitin. I made the changes to make sure that: 1. ISO will be deleted from the UI, but it is not deleted from the secondary storage as long as it is attached to a VM. 2. The storage cleanup thread will check whether the iso is attached to any vm, if not, it removes the ISO from the secondary storage. 3. Detach operation is now working which was failing before for the vms having attached iso(deleted). Description ------- Currently no warning or confirmation is given or required to delete an iso which is attached to a virtual machine. Fixing this issue using “force” delete option. If an admin or a user deletes an ISO which is attached to a vm: 1. Without force option; gives a warning that ISO is attached to vm “Failed to delete iso. It is currently attached to virtual machine. Please detach it before deleting”. 2. With force option: first detach the ISO from all vms and then deletes the ISO. This addresses bug CLOUDSTACK-357. Diffs (updated) ----- server/src/com/cloud/storage/dao/VMTemplateHostDaoImpl.java 4d1ac02 server/src/com/cloud/template/HyervisorTemplateAdapter.java fe6bc2a server/src/com/cloud/template/TemplateAdapterBase.java fa677ac server/src/com/cloud/template/TemplateManagerImpl.java f9cf277 server/src/com/cloud/vm/dao/UserVmDao.java 9fbcde3 server/src/com/cloud/vm/dao/UserVmDaoImpl.java f2fc10b Diff: https://reviews.apache.org/r/7660/diff/ Testing ------- Verified locally. Tested for some cases: 1. Deleting iso(not attached to any vm) 2. Deleting iso(attached to multiple vms in same domain) 3. Deleting iso(attached to multiple vms in different domains) For admin/user Thanks, deepti dohare
