2010/9/23 Šplíchal Jiří <splic...@tovek.cz>: > Hi, > I just published several changes in the memory_leaks branch. Now, following > tests have been fixed > + testRAMDirectory
Some possible lost of memory and some conditions on uninitialised values in MockRAMDirectory. I think we once talked about. Fixed the last one here. The possible lost memory may be related to the FSDirectory. I remember, that I once observed this issue and solved it by extending the shutdown function. I will take a look. > + testsearch Ok, but some possible lost of memory. The same as in testRAMDirectory. > + testRangeFilter No memory leaks with valgrind. Which commits fixed the memory leaks here? > + testConstantScoreQueries No memory leaks with valgrind. Which commits fixed the memory leaks here? > + testsort No memory leaks with valgrind. Which commits fixed the memory leaks here? > + testdatefilter Ok, but some possible lost of memory. The same as in testRAMDirectory. > + testBitSet Ok. No memory leaks with valgrind. > + testExtractTerms. No memory leaks with valgrind. Which commits fixed the memory leaks here? > We still have to solve the memory leaks produced by the following tests: > - testatomicupdates > - testindexreader > - testanalyzers > - testindexwriter > - testIndexModifier > - testAddIndexesNoOptimize > - testutf8 > > Please, could someone check the changes especially those in the core files: > Array.h, DocumentsWriterThreadState.cpp, IndexWriter.cpp? - RefCountArray::deleteValues() [1]: The gcc misses a template parameter here (corrected it), but the fix seems to be plausible. - ArrayBase<>::resize() [2]: Plausible. - DocumentsWriter::ThreadState::trimFields() [3]: Plausible. - IndexWriter::setMergeScheduler() [4]: Plausible. - IndexWriter::closeInternal() [4]: Here, I don't understand, why deleting rollbackSegmentInfos outside the mutex protected code block fixes a memory leak. Veit [1] http://clucene.git.sourceforge.net/git/gitweb.cgi?p=clucene/clucene;a=commit;h=73bac8355bba837028e532b975d0694fe5caf0c5 [2] http://clucene.git.sourceforge.net/git/gitweb.cgi?p=clucene/clucene;a=commit;h=136ba14e03e08afa71d366dbe7c60538ddb58ae5 [3] http://clucene.git.sourceforge.net/git/gitweb.cgi?p=clucene/clucene;a=blobdiff;f=src/core/CLucene/index/DocumentsWriterThreadState.cpp;h=cd5e6ffcc65ac734ebe726f441cd35ee41483743;hp=eef494622c3eb3d89f367b46ac44723d79433da9;hb=c87131a924443c1c1c66080614ea5fe3dda220ee;hpb=136ba14e03e08afa71d366dbe7c60538ddb58ae5 ------------------------------------------------------------------------------ Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev _______________________________________________ CLucene-developers mailing list CLucene-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/clucene-developers
