I just had a quick look on Array.h. ArrayBase<T>::resize seems to be flawed in so many ways that I just went ahead and rewrote it. Jiri, your fix was correct, but it wasn't complete (for example: if deleteValues was passed true before values was initialized, it would crash).
I checked in what I have done to master since the tests pass and I don't think I could break anything with it. Please test and let me know. I'm a bit swamped atm so I hope to review the rest of the pending items soon. Itamar. On 23/9/2010 11:19 PM, Šplíchal Jiří wrote: > Hi, > I just published several changes in the memory_leaks branch. Now, following > tests have been fixed > + testRAMDirectory > + testsearch > + testRangeFilter > + testConstantScoreQueries > + testsort > + testdatefilter > + testBitSet > + testExtractTerms. > > We still have to solve the memory leaks produced by the following tests: > - testatomicupdates > - testindexreader > - testanalyzers > - testindexwriter > - testIndexModifier > - testAddIndexesNoOptimize > - testutf8 > > Please, could someone check the changes especially those in the core files: > Array.h, DocumentsWriterThreadState.cpp, IndexWriter.cpp? > > Jiri > > > -----Original Message----- > From: Veit Jahns [mailto:nuncupa...@googlemail.com] > Sent: Wednesday, September 22, 2010 9:32 PM > To: clucene-developers@lists.sourceforge.net > Subject: Re: [CLucene-dev] Current branches state > > 2010/9/20 Šplíchal Jiří<splic...@tovek.cz>: >> I tested once more our code in order to check the memory leaks. >> Here is the list of leaking test suites: >> >> [...] >> >> Let us get rid of the leaks! I will start from the bottom > Ok. As I was examining memory leaks in CLucene, I observed, that some > leaks are caused by the tests themselves. I will take a look what is > still left from this effort. > >> with the testExtractTerms test. Should we create a new branch for this issue? > AsI understand Itamar proposal, I'd say yes. > > Veit > > ------------------------------------------------------------------------------ > Start uncovering the many advantages of virtual appliances > and start using them to simplify application deployment and > accelerate your shift to cloud computing. > http://p.sf.net/sfu/novell-sfdev2dev > _______________________________________________ > CLucene-developers mailing list > CLucene-developers@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/clucene-developers > ------------------------------------------------------------------------------ > Nokia and AT&T present the 2010 Calling All Innovators-North America contest > Create new apps& games for the Nokia N8 for consumers in U.S. and Canada > $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing > Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store > http://p.sf.net/sfu/nokia-dev2dev > _______________________________________________ > CLucene-developers mailing list > CLucene-developers@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/clucene-developers ------------------------------------------------------------------------------ Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb _______________________________________________ CLucene-developers mailing list CLucene-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/clucene-developers
