On 06/13/2015 01:41 PM, Michael Scott wrote: > I've implemented some changes to cmake.cxx and cmake.h, to implement > setting the CMAKE_ERROR_DEPRECATED and CMAKE_WARN_DEPRECATED variables > via command line options, for the Mantis issue 0014669, in a generic GCC > style pattern. I've attached the proposed patch to this email, does this > look like a sensible implementation?
Thanks for working on this. Here are some comments: * Please use 2 spaces and no tabs for indentation. * Please extend Tests/RunCMake/CommandLine to cover this or find another appropriate test to update. All options need coverage, including the error cases. * The cmHasLiteralPrefix helper function may be useful in place of "x.find(...) == 0". Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
