On 06/24/2015 05:30 PM, Michael Scott wrote:
> Thanks for the comments, here is the previous patch, with the suggested
> amendments.
Thanks.
This hunk:
> - void SetSuppressDevWarnings(bool v)
> - {
> - this->SuppressDevWarnings = v;
> - this->DoSuppressDevWarnings = true;
> - }
causes the cmake-gui Qt dialog to fail to compile:
$ git grep SetSuppressDevWarnings
Source/QtDialog/QCMake.cxx:
this->CMakeInstance->SetSuppressDevWarnings(this->SuppressDevWarnings);
Sorry I didn't notice that last time.
Please enable the BUILD_QtDialog option at CMake build time to
build this part and make sure it compiles after the changes.
It would be nice to also provide settings in cmake-gui for
these deprecation levels (as there is for -Wdev), but I won't
make that a requirement for acceptance of the patch.
Thanks,
-Brad
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
