On 06/23/2015 03:57 PM, Michael Scott wrote: > I've implemented some changes to cmake.cxx and cmake.h, to implement > setting the CMAKE_ERROR_DEPRECATED and CMAKE_WARN_DEPRECATED variables > via command line options, for the Mantis issue 0014669, in a generic GCC > style pattern. I've taken on board the previous suggestions, including > adding tests for the new options and updating the cmake application > options documentation. I've attached the proposed patch to this email, > please let me know if there are any incorrect changes in the patch.
Thanks. Here are some comments: * Please update the Help/variable/CMAKE_*_DEPRECATED.rst documents to mention the appropriate command-line options, perhaps with a :manual:`cmake(1)` link. * Please add a Help/release/dev/cmake-Wdeprecated.rst file with a release note mentioning the options. * Please ensure all sources added/modified by the patch have a newline on the last line (but not a trailing blank line). Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
