On 09/10/2014 03:42 PM, Nils Gladitz wrote:
> extract everything into its own class "cmConditionEvaluator" and have it 
> keep everything that was being passed around as members instead.

Good work.  I think the net change is now in good shape.  To make
it easier to review now and bisect in the future, please rewrite
the topic to start with refactoring cmIfCommand to split out the
cmConditionEvaluator, and then add the rest of the changes.

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to