On 11.09.2014 19:14, Brad King wrote:
On 09/11/2014 01:07 PM, Nils Gladitz wrote:
I would have to add back lines to cmConditionEvaluator.cxx which where
removed while they were still in cmIfCommand.cxx.
Look at the diff in commit 5922fc2c and you will see all those lines as
removed from cmIfCommand. You can put them all in cmConditionEvaluator.
Some of the work is manual. Effectively you are re-doing the refactoring
from scratch without the CMP0054 pieces. The use of Git up to this point
is just to help get close.
The reason I'm asking for this is that the refactoring done to create
cmConditionEvaluator is more intrusive than the original CMP0054 change.
It will be much easier to convince myself that the whole thing is correct
if I can see the refactoring done first and independently.
Certainly, I don't argue against the change itself.
It sounded like there might have been some sort of git magic that would
have made it less manual.
Thanks.
Nils
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
