On Sun, Jan 14, 2018 at 11:46:34AM +0100, SF Markus Elfring wrote: > > Look at the script code just under the comment "For context mode" and just > > under the comment "For patch mode". Both of them use m. > > I would like to apologise that I overlooked these places somehow.
Rather than apologising, start looking the SmPL grammar documentation first. For eg. You asked about the 'initialize' code so take your time and read what actually initialize does rather than writing about each and very change. If its not mentioned there then ask Julia, that is what I do. But first search around the documentation. > > > __ are typically used in sparse annotations. Now, again look for what __attribute__ means and why is it used ? How is it benefiticial to sparse for static analysis. Even wikipedia explains that! > Is this search pattern worth for a corresponding comment in the Python code? > > > How do you think about to pass it to the method “compile” directly (without > the variable “pattern”)? Would removing that boost performance ? pattern variable improves readability and I mean people can easily guess "Ok he searching for a pattern ..." Whatever you wish to suggest, don't just email directly! Look for documentation, explore, test the patch with the -next tree and show the benchmarks to the relevant people. And finally prepare a patch and send upstream. Respect the developers, they also have their job. Don't ask trivial questions to Julia or any other develper before searching and exploring. She also has her research and other productive stuff to do and not just sitting idle replying to each and every email. Also, don't linger on *trivial* stuffs that improve the comment, add a tabspace etc. Lastly, you have a habit of saying: "How about this ... ?' "How about that ... ?" "What if ... ?" You have all the tools, documentations, source code, and you can explore it yourself too before asking. That is what we call *opensource* :-) BONUS: https://www.kernel.org/doc/html/latest/dev-tools/coccinelle.html http://coccinelle.lip6.fr/docs/index.html https://en.wikipedia.org/wiki/Sparse#Annotations -- Thanks Himanshu Jha _______________________________________________ Cocci mailing list [email protected] https://systeme.lip6.fr/mailman/listinfo/cocci
