> 4. Is is more efficient to use the Python key word “in” to look for
>    a short string instead of fiddling with the programming interface
>    for regular expressions?

If you test it and find that it is significantly more efficient, then
please send a patch accordingly.

>
> 5. Please omit the variable “msg” in the last SmPL rule.
>    The need data can be passed directly instead.

The use of the msg variable is common in the semantic patches in the
kernel.  Ampng other things it increases the chance that the line will fit
in 80 characters.  It is not completely a success here, but at least it is
more of a success than it would be otherwise.

julia
_______________________________________________
Cocci mailing list
[email protected]
https://systeme.lip6.fr/mailman/listinfo/cocci

Reply via email to