> From: Stefano Mazzocchi [mailto:[EMAIL PROTECTED]]
> 
> Vadim Gritsenko wrote:
> 
> > you have product catalog sub-sitemap:
> >
> >  <!-- high precedence URL patterns -->
> >  <map:match>...</map:match>
> >
> >  <!-- process request parameters productId=xxx&addToComparison=yes
-->
> >  <map:act type="add-to-comparison"/>
> >
> >  <map:act type="product-selection">
> >    <map:generate/>
> >    <map:serialize/>
> >  </map:act>
> >
> >  <!-- low precedence URL patterns -->
> >  <map:match>...</map:match>
> >
> > Example might be not perfect, but it gives an idea...
> 
> Yeah, gives me the idea that the whole concept is screwed and can
> potentially be very harmful in the future!

Not sure that I see what you see... Could you re-do this fragment so it
is not screwed? It would help me understand your vision.


> > From the above fragment, the low precedence URL patterns are
> > unreachable!
> 
> I have the perception that allowing actions (that are *always*
executed)
> to happen side by side to matchers (which are not always executed) can
> lead to potentially dangerous results, like your example above!
> 
> if a cocoon developer can make such a mistake, imagine what a cocoon
> newbie can do!

Please, explain what is so dangerous here - so I would not make same
mistake in the future ;)


> > > The "theme-selection" action above can be either
> > > pre/intra/post-matching
> > > depending on the precedence order of URL patterns. An
intra-matching
> > > example :
> > >
> > > <!-- non-themed high precedence URL patterns -->
> > > <map:match>...</map:match>
> > >
> > > <!-- themed URL patterns -->
> > > <map:act type="theme-selection">
> > >   <map:match>...</map:match>
> > >   <map:match>...</map:match>
> > > </map:act>
> > >
> > > <!-- non-themed low precedence URL patterns -->
> > > <map:match>...</map:match>
> > >
> > > With this new criteria :
> > > +1 for pre/intra/post-matching non-empty actions
> > > +1 for pre-matching empty actions : this can be used to setup some
> > > application-level context
> >
> > Fully agree with you here.
> >
> > > -0 for intra/post-matching empty actions : I don't see any real
> > > usefullness for them.
> >
> > May be you can change your mind at least for +0? ;)
> 
> Thinking about it more, I'd be in favor of:
> 
> 1) allowing empty actions to live at the same level of matchers.
> 
> 2) non-empty actions at the matching level *must* contain a matcher.
> 
> It is impossible to change the semantics of 'getting out of the
sitemap'
> without creating back incompatibilities, so this states that 'post'
> match-level action are never reacheable.

Not exactly correct... they are reachable...

> 
>  <pipeline>
>   <act>
>   <match>
>   <act>
>   <match>
>   <act>
>  </pipeline>
> 
> the third one is never reached.

It *is* reached if none of the matchers are matched *or* if matched
matchers had no <map:serialize|mount>. In these cases, last actions is
executed right before <map:handle-errors/>.

Vadim


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, email: [EMAIL PROTECTED]

Reply via email to