On Tue, Apr 27, 2010 at 11:16 PM, Facundo Batista <[email protected]>wrote:
> On Tue, Apr 27, 2010 at 3:30 PM, claudio canepa <[email protected]> > wrote: > > > 1. in cocos.menu.Menu.__init__ schedule a do_nothing (tested, works) > > or > > 2. in cocos.menu.Menu boost temporaly the fps when on_key_press and > key.DOWN > > or KEYUP (tested, works) > > or > > 3. modify the relevant tests to add a do_nothing in the Menu subclass > > (tested, works). Add the appropriate comment so that users knows why the > > do_nothing is used. Anyway, they must know this for scenes that not > contain > > a menu. > > I favor the third, because it exposes a behavior that the user must know, > > but I open to adopt other. > > Agree that if user finds this behaviour in other scene, she would need > to find out why it's happening, and learn it. > > But, I'd go for the least surprising behaviour. Don't leave it hard to > get it right with a comment "you should know this", make it the way > that it just works. > > So, I'd go for 1 or 2, I think 1 is the simplest, right? > > -- > . Facundo > > Yes, 1 will be simpler, and 2 only will save some batery if the user left running such a menu screen for a long time. Will commit 1. -- claudio -- You received this message because you are subscribed to the Google Groups "cocos2d discuss" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/cocos-discuss?hl=en.
