at r1004 all test in test dir were working
while testing the built package at r1022,
test_scrolling_manager_without_tiles.py
gave me:
Traceback (most recent call last):
File "D:\tmp\cocos2d-0.4rc0\test\test_scrolling_manager_without_tiles.py",
lin
e 349, in <module>
director.run(scene)
File "D:\tmp\cocos2d-0.4rc0\test\..\cocos\director.py", line 436, in run
self._set_scene( scene )
File "D:\tmp\cocos2d-0.4rc0\test\..\cocos\director.py", line 528, in
_set_scen
e
scene.on_enter()
File "D:\tmp\cocos2d-0.4rc0\test\test_scrolling_manager_without_tiles.py",
lin
e 213, in on_enter
super(TestScene, self).on_enter()
File "D:\tmp\cocos2d-0.4rc0\test\..\cocos\scene.py", line 117, in on_enter
super(Scene, self).on_enter()
File "D:\tmp\cocos2d-0.4rc0\test\..\cocos\cocosnode.py", line 505, in
on_enter
c.on_enter()
File "D:\tmp\cocos2d-0.4rc0\test\..\cocos\layer\scrolling.py", line 182, in
on
_enter
super(ScrollingManager, self).on_enter()
File "D:\tmp\cocos2d-0.4rc0\test\..\cocos\layer\base_layers.py", line 87, in
o
n_enter
super(Layer, self).on_enter()
File "D:\tmp\cocos2d-0.4rc0\test\..\cocos\cocosnode.py", line 505, in
on_enter
c.on_enter()
File "D:\tmp\cocos2d-0.4rc0\test\test_scrolling_manager_without_tiles.py",
lin
e 134, in on_enter
self.scene = self.get_ancestor(cocos.scene.Scene)
AttributeError: can't set attribute
Going back in time it was r1007 which broke the thing.
Looking at the diff ...
ok, the problem is you added a property 'scene', read-only, that explains
the traceback, I can fix by not setting it and reading from your property.
But, lets see if it is an useful addition:
- the value is easy to obtain, no great easiness value
( self.get_ancestor(cocos.scene.Scene) )
- each access to property needs a function call, vs the app sets a
member scene and access only a member
- cocosnode gets bloated, and is enough big atm
In addition, you do the same for a property 'layer' that performs
self.get_ancestor(layer.Layer)
And, like with the test that broke in cocos, I suspect that there are more
than two script / apps in the world using a member .scene , which will broke
with this change.
So, can you agree to delete this properties ? (And fix dependencies on this
if you introduced some ?)
Going to dinner just now, see later
--
claudio
--
You received this message because you are subscribed to the Google Groups
"cocos2d discuss" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/cocos-discuss?hl=en.
