[GitHub] trafodion pull request #1417: [TRAFODION-2917] Refactor Trafodion implementa...

[selvaganesang]

Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1417#discussion_r164211946
  
    --- Diff: core/sql/executor/ExHbaseAccess.cpp ---
    @@ -502,6 +506,8 @@ void ExHbaseAccessTcb::freeResources()
          NADELETEBASIC(directRowBuffer_, getHeap());
       if (colVal_.val != NULL)
          NADELETEBASIC(colVal_.val, getHeap());
    +  if (hdfsClient_ != NULL) 
    +     NADELETE(hdfsClient_, HdfsClient, getHeap());
     }
    --- End diff --
    
    Yes. It is a good catch. I will fix this too in my next commit.  This won't 
cause memory leak as such because the heap is destroyed.


---