Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1417#discussion_r164275414
  
    --- Diff: core/sql/executor/ExFastTransport.cpp ---
    @@ -1248,6 +1279,23 @@ void 
ExHdfsFastExtractTcb::createSequenceFileError(Int32 sfwRetCode)
       updateWorkATPDiagsArea(diagsArea);
     }
     
    +void ExHdfsFastExtractTcb::createHdfsClientFileError(Int32 
hdfsClientRetCode)
    +{
    +  ContextCli *currContext = GetCliGlobals()->currContext();
    +
    +  ComDiagsArea * diagsArea = NULL;
    +  char* errorMsg = 
hdfsClient_->getErrorText((HDFS_Client_RetCode)hdfsClientRetCode);
    +  ExRaiseSqlError(getHeap(),
    +                  &diagsArea,
    +                  (ExeErrorCode)(8447),
    +                  NULL, NULL, NULL, NULL,
    +                  errorMsg,
    +                (char *)currContext->getJniErrorStr().data());
    +  //ex_queue_entry *pentry_down = qParent_.down->getHeadEntry();
    --- End diff --
    
    Consider removing these 2 lines of comments in next commit. There are 
similar lines in the createSequenceFileError() method that could be removed.


---

Reply via email to