[GitHub] trafodion pull request #1417: [TRAFODION-2917] Refactor Trafodion implementa...

[sureshsubbiah]

Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1417#discussion_r164276571
  
    --- Diff: core/sql/executor/ExHdfsScan.cpp ---
    @@ -283,6 +285,8 @@ void ExHdfsScanTcb::freeResources()
          ExpLOBinterfaceCleanup(lobGlob_, (NAHeap 
*)getGlobals()->getDefaultHeap());
          lobGlob_ = NULL;
       }
    +  if (hdfsClient_ != NULL) 
    +     NADELETE(hdfsClient_, HdfsClient, getHeap());
    --- End diff --
    
    Same comment as Eric on ExHBaseAccess::freeResources(). Should we release 
loggingFileName_ here? Constructor guarantees it is never null.


---