Github user sandhyasun commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1612#discussion_r198646970
--- Diff: core/sql/cli/SessionDefaults.cpp ---
@@ -108,6 +108,7 @@ static const SessionDefaults::SessionDefaultMap
sessionDefaultMap[] =
SDEntry(SessionDefaults::SCHEMA, SCHEMA,
SessionDefaults::SDT_ASCII, TRUE, TRUE, FALSE, FALSE),
SDEntry(SessionDefaults::STATISTICS_VIEW_TYPE, STATISTICS_VIEW_TYPE,
SessionDefaults::SDT_ASCII, FALSE, FALSE, TRUE, TRUE),
SDEntry(SessionDefaults::SUSPEND_LOGGING, SUSPEND_LOGGING,
SessionDefaults::SDT_BOOLEAN, FALSE, FALSE, TRUE, FALSE),
+ SDEntry(SessionDefaults::USE_LIBHDFS, USE_LIBHDFS,
SessionDefaults::SDT_BOOLEAN, TRUE, TRUE, FALSE, FALSE),
--- End diff --
It's fine if the DDL interfaces use the new implementation since we just
create or drop. Since you took care of the 2 utility operations UPDATE and
EXTRACT, looks like we are covered all the main functionality with this toggle
now. Looks good +1 . Can merge as soon as the test passes.
---
