Github user selvaganesang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1612#discussion_r198635546
--- Diff: core/sql/executor/HdfsClient_JNI.h ---
@@ -171,7 +175,7 @@ class HdfsClient : public JavaObjectInterface
~HdfsClient();
static HdfsClient *newInstance(NAHeap *heap, ExHdfsScanStats *hdfsStats,
HDFS_Client_RetCode &retCode, int hdfsIoByteArraySizeInKB = 0);
static HdfsClient *getInstance();
- static void deleteInstance();
+ static void deleteInstance(HdfsClient *hdfsClient);
--- End diff --
Attempted to make it as non-static method. But it involves the deletion of
itself. Hence I decided to keep it as static for better readability.
void HdfsClient::deleteInstance(HdfsClient *hdfsClient)
{
hdfsClient->hdfsClose();
NADELETE(hdfsClient, HdfsClient, hdfsClient->getHeap());
}
---
