Github user selvaganesang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1612#discussion_r198287745
--- Diff: core/sql/cli/SessionDefaults.cpp ---
@@ -108,6 +108,7 @@ static const SessionDefaults::SessionDefaultMap
sessionDefaultMap[] =
SDEntry(SessionDefaults::SCHEMA, SCHEMA,
SessionDefaults::SDT_ASCII, TRUE, TRUE, FALSE, FALSE),
SDEntry(SessionDefaults::STATISTICS_VIEW_TYPE, STATISTICS_VIEW_TYPE,
SessionDefaults::SDT_ASCII, FALSE, FALSE, TRUE, TRUE),
SDEntry(SessionDefaults::SUSPEND_LOGGING, SUSPEND_LOGGING,
SessionDefaults::SDT_BOOLEAN, FALSE, FALSE, TRUE, FALSE),
+ SDEntry(SessionDefaults::USE_LIBHDFS, USE_LIBHDFS,
SessionDefaults::SDT_BOOLEAN, TRUE, TRUE, FALSE, FALSE),
--- End diff --
I found that it wasn't possible to do like CQD LOB_MAX_SIZE because this
setting is needed in ExLOBGlobals constructor. The best way is to transform it
into SSD, if the settings is needed in CLI layer. Then I realized that CQD is
effective but SSD isn't effective if the CQD is set in defaults table.
Currently if you set this CQD to 'ON' in defaults tables, the portions of the
code that created ExLobGlobals from CLI layer still uses newer implementation.
USE_LIBHDFS is just fall back option till such time the new implementation
is tested. Then, I would think the code and the CQD can be retired. I haven't
it figured out how much impact is not to use USE_LIBHDFS settings from the CLI
layer when we need to fallback. I have run core/TEST130 with CQD USE_LIBHDFS
'ON' in defaults table.
Because it is a generic issue of not transforming to SSD from CQD when it
is defaults table, I thought that I will handle it via another PR. In addition,
this would require changes to an area that I am not yet comfortable with.
---
