Github user robertamarton commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1721#discussion_r225014659
--- Diff: core/sql/common/ComMisc.cpp ---
@@ -357,3 +358,119 @@ NABoolean ComTrafReservedColName(
return FALSE;
}
+
+
+Int32 ComGenerateUdrCachedLibName(NAString libname,Int64 redeftime,
NAString schemaName, NAString userid, NAString &cachedLibName, NAString
&cachedLibPath)
+{
+ NAString libPrefix, libSuffix;
+ struct stat statbuf;
+ NAString redefTimeString = Int64ToNAString(redeftime);
+ size_t lastDot = libname.last('.');
+ if (lastDot != NA_NPOS)
--- End diff --
I was able to create a library that contains special characters: create
library "name/sih.char%" file '/mnt/rmarton/gitws/traf-plus'; So an embedded
period is allowed. I am wondering if, at least until we allow more special
characters in names, library names should follow rules of other identifiers
and return error 1422 if the specified name contains characters not allow in
hbase. (isValidHbaseName).
---