Github user robertamarton commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1721#discussion_r225015093
  
    --- Diff: core/sql/sqlcomp/CmpSeabaseDDLupgrade.cpp ---
    @@ -314,7 +326,7 @@ short 
CmpSeabaseMDupgrade::executeSeabaseMDupgrade(CmpDDLwithStatusInfo *mdui,
       // now as they are stateless
       CmpSeabaseUpgradeRepository upgradeRepository;
       CmpSeabaseUpgradePrivMgr upgradePrivMgr;
    -
    +  CmpSeabaseUpgradeLibraries upgradeLibraries;
    --- End diff --
    
    Since we create repository, libraries, and then privmgr, perhaps 
upgradeLibraries should come before upgradePrivMgr?


---

Reply via email to