Github user robertamarton commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1721#discussion_r225015029
  
    --- Diff: core/sql/sqlcomp/CmpSeabaseDDLroutine.cpp ---
    @@ -1925,3 +2730,568 @@ short 
CmpSeabaseDDL::createSeabaseLibmgrCPPLib(ExeCliInterface * cliInterface)
         }
       return 0;
     }
    +
    +short CmpSeabaseDDL::upgradeLibraries(ExeCliInterface * cliInterface,
    +                                  CmpDDLwithStatusInfo *mdui)
    +{
    +Lng32 cliRC = 0;
    +
    +  while (1) // exit via return stmt in switch
    +    {
    +      switch (mdui->subStep())
    +        {
    +        case 0:
    +          {
    +            mdui->setMsg("Upgrade Libraries: Started");
    +            mdui->subStep()++;
    +            mdui->setEndStep(FALSE);
    +        
    +            return 0;
    +          }
    +          break;
    +      
    +        case 1:
    +          {
    +            mdui->setMsg("  Start: Drop Old Libraries");
    +            mdui->subStep()++;
    +            mdui->setEndStep(FALSE);
    +        
    +            return 0;
    +          }
    +          break;
    +
    +        case 2:
    +          {
    +            // drop old libraries
    +            if (dropLibraries(cliInterface, TRUE/*old */))
    +              return -3;  // error, but no recovery needed 
    --- End diff --
    
    unable to drop old libraries, it is okay - that is because it will just use 
up space but not cause any difficulties?


---

Reply via email to