Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/28#discussion_r34690758
--- Diff: core/conn/jdbc_type2/native/CSrvrConnect.cpp ---
@@ -457,6 +461,23 @@ SRVR_STMT_HDL *SRVR_CONNECT_HDL::getSrvrStmt(long
dialogueId,long stmtId,long
FUNCTION_RETURN_PTR(NULL,(NULL));
}
+SRVR_STMT_HDL *SRVR_CONNECT_HDL::getInternalSrvrStmt(long dialogueId,
const char* stmtLabel, long *sqlcode)
+{
+ FUNCTION_ENTRY("getInternalSrvrStmt",("dialogueId=0x%08x,
stmtLabel=0x%08x, sqlcode=0x%08x",
+ dialogueId,
+ stmtLabel,
+ sqlcode));
+
+ SRVR_STMT_HDL *pSrvrStmt = NULL;
+
+ MapOfInternalSrvrStmt::iterator iterOfStmtId =
mapOfInternalSrvrStmt.find(stmtLabel);
+ if( !(iterOfStmtId == mapOfInternalSrvrStmt.end()) )
+ pSrvrStmt =(SRVR_STMT_HDL *)iterOfStmtId->second;
+
+ if(pSrvrStmt != NULL)
+ FUNCTION_RETURN_PTR(pSrvrStmt,(NULL));
+}
--- End diff --
What happens if pSrvrStmt is NULL? (I don't see a return statement for this
case.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
