Github user arvind-narain commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/28#discussion_r34718734
--- Diff: core/conn/jdbc_type2/native/CSrvrConnect.cpp ---
@@ -268,10 +268,10 @@ void SRVR_CONNECT_HDL::addSrvrStmt(SRVR_STMT_HDL
*pSrvrStmt,BOOL internalStmt)
mapOfInternalSrvrStmt[pSrvrStmt->stmtName]= pSrvrStmt; // +++ map
error
}
-
//End of Soln. No.: 10-100202-7923
count++;
+ //pSrvrStmt->myKey = count;
--- End diff --
Thanks for removing some unneeded comments. Is this particular one needed ?
In general if it might be good to clean up the method being touched (remove sol
numbers, commented out code if not needed or add more comments, remove any MFC
related code etc)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
