Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/28#discussion_r34705621
--- Diff: core/conn/jdbc_type2/native/SqlInterface.cpp ---
@@ -4440,3 +4440,45 @@ void CreateModulePlan(long inputParamCount,
InputDescInfo *inputDescInfo, char *
}
}
}
+
+SQLRETURN COMMIT_ROWSET(long dialogueId, bool& bSQLMessageSet,
odbc_SQLSvc_SQLError* SQLError, Int32 currentRowCount)
+{
+ SQLRETURN retcode;
+ long sqlcode;
+ SQLValueList_def inValueList;
+ inValueList._buffer = NULL;
+ inValueList._length = 0;
+
+ SRVR_STMT_HDL *CmwSrvrStmt = getInternalSrvrStmt(dialogueId,
"STMT_COMMIT_1", &sqlcode);
+ /* Should process the error here if CmwSrvrStmt is NULL */
--- End diff --
What's the risk in not having error processing here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
