Github user selvaganesang commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/748#discussion_r82661676
--- Diff: core/sql/common/Collections.h ---
@@ -2389,10 +2389,15 @@ template <class T> class NASimpleArray : private
NAArray<T>
// operator s new and delete get inherited from private base class,
// make them publicly available by the following inline functions
- static inline void * operator new(size_t size, CollHeap* h=0)
+ static inline void * operator new(size_t size, CollHeap* h)
{ return NAArray<T>::operator new(size,
h); }
static inline void operator delete(void *buffer)
{ NAArray<T>::operator delete(buffer); }
+
+ inline void setHeap(CollHeap *heap)
--- End diff --
May not be good idea to do setHeap after it is constructed. This can
possibly result in different heaps to be used for different elements and cause
core dumps
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
