Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/748#discussion_r82684252
  
    --- Diff: core/sql/common/Ipc.h ---
    @@ -572,7 +572,9 @@ class IpcConnection : public NABasicObject
     
       static const char *getConnectionStateString(IpcConnectionState s);
     
    -  IpcConnection() : fileNumForIOCompletion_(InvalidGuaFileNumber) {}
    + IpcConnection() 
    +   : fileNumForIOCompletion_(InvalidGuaFileNumber),
    +    recvStreams_(NULL) {} // recvStream on C++ heap
    --- End diff --
    
    I don't think that heap is available here. I am way of making this change 
any bigger in scope by changing how IpcConnection objects are constructed. So 
this too will have to be deferred. We could make a list of all classes with 
NACollection data members on the system heap and then come back of them one by 
one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to