Github user sureshsubbiah commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/748#discussion_r82682913
--- Diff: core/sql/export/ComDiags.cpp ---
@@ -1671,8 +1671,8 @@ ComDiagsArea::ComDiagsArea (CollHeap* ptr):
IpcMessageObj(IPC_SQL_DIAG_AREA,0),
ComDiagsArea::ComDiagsArea () :
IpcMessageObj(IPC_SQL_DIAG_AREA,0),
collHeapPtr_(NULL),
- errors_(),
- warnings_(),
+ errors_(NULL),
--- End diff --
Yes.
This is the ComDiagsArea constructor without a heap pointer. There is
another one with a heap pointer. I see two options to avoid this leak
a) try to get rid of this constructor OR
b) Make sure that these NACollection objections are cleared at the end of
their lifecycle.
Either of them would take some effort. I don't have a fix that can be
included now. I would claim that this code does no worse than before here,
while making marginal improvements in other places. It also ensures that no one
unintentionally creates objects on the system heap.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
