Github user zellerh commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/826#discussion_r87315691
--- Diff: core/sql/optimizer/BindWA.h ---
@@ -685,6 +685,8 @@ class BindScope : public NABasicObject
// --------------------------------------------------------------------
RelExpr *&getSequenceNode() { return sequenceNode_; };
+ ValueIdMap &getNcToOldMap() { return ncToOldMap_;}
--- End diff --
For new code, could you make a "get" and a "set" method instead of
returning a writable reference. I know a lot of old code still has this style
of method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
