Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/826#discussion_r87304583
  
    --- Diff: core/sql/optimizer/BindRelExpr.cpp ---
    @@ -2436,6 +2437,32 @@ Scan *RelExpr::getLeftmostScanNode() const
       return (Scan *)result;
     }
     
    +
    +
    +Join * RelExpr::getLeftJoinChild() const
    +{
    +  RelExpr *result = (RelExpr *)this;
    +  
    +  while(result)
    +    {
    +      if (result->getOperatorType() == REL_LEFT_JOIN) break;
    +      result = result->child(0);
    +    }
    +  return (Join *)result;
    +}
    +
    +RelSequence* RelExpr::getOlapChild() const
    --- End diff --
    
    Might be nice to make this a more generic method and pass the operator type 
in as a parameter, so we don't have two new methods on RelExpr that have only 
very limited use? Sorry, that would mean you have to do the dirty cast in the 
caller.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to