Github user zellerh commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/826#discussion_r87305909
--- Diff: core/sql/optimizer/BindRelExpr.cpp ---
@@ -10298,10 +10331,17 @@ RelExpr *Insert::bindNode(BindWA *bindWA)
}
if (isUpsertThatNeedsMerge(isAlignedRowFormat, omittedDefaultCols,
omittedCurrentDefaultClassCols)) {
- boundExpr = xformUpsertToMerge(bindWA);
- return boundExpr;
+ if (CmpCommon::getDefault(TRAF_UPSERT_TO_EFF_TREE) == DF_OFF)
+ {
+ boundExpr = xformUpsertToMerge(bindWA);
+ return boundExpr;
+ }
+ else if( CmpCommon::getDefault(TRAF_UPSERT_TO_EFF_TREE) == DF_ON)
+ boundExpr = xformUpsertToEfficientTree(bindWA);
+
--- End diff --
This does nothing if TRAF_UPSERT_TO_EFF_TREE is set to something other than
ON or OFF, is that ok? In this case we could produce incorrect results as far
as I understand.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
