Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/946#discussion_r99958921
--- Diff: core/sql/optimizer/Inlining.cpp ---
@@ -618,10 +618,14 @@ RETDesc
*GenericUpdate::createOldAndNewCorrelationNames(BindWA *bindWA, NABoolea
rd = new (bindWA->wHeap()) RETDesc(bindWA);
}
+ /* if ((getOperatorType() != REL_UNARY_INSERT) ||
+ getUpdateCKorUniqueIndexKey() ||
+ ((getOperatorType() == REL_UNARY_INSERT) &&((Insert
*)this)->isMerge()) ||
+ ((getOperatorType() == REL_UNARY_INSERT) && ((Insert
*)this)->isUpsert() && (CmpCommon::getDefault(TRAF_UPSERT_TO_EFF_TREE) == DF_ON
))) */
--- End diff --
It's better to not leave this old code here... it just clutters things up
and makes reading the code more confusing. We can always recover the old code
from the repository if needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
