Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/946#discussion_r100099385
  
    --- Diff: core/sql/regress/executor/EXPECTED015.SB ---
    @@ -1961,51 +1970,51 @@ TRAFODION_MERGE
     +>(select d.id from DEC1 d where d.codeValue = ?),  ? ) ;
     
     --- SQL command prepared.
    ->>execute explainIt;
    +>>execute explainItEff;
     
     OPERATOR        
     ----------------
     
    -TRAFODION_MERGE 
    +SEQUENCE        
     
     --- 1 row(s) selected.
     >>
     >>prepare XX from UPSERT INTO DE (ID, dataElementConceptID, valueDomainID) 
 
     +>VALUES  (1,  (select d.id from DEC1 d where d.codeValue = ?),  3 ) ;
     
     --- SQL command prepared.
    ->>execute explainIt;
    +>>execute explainItEff;
     
     OPERATOR        
     ----------------
     
    -TRAFODION_MERGE 
    +SEQUENCE        
     
     --- 1 row(s) selected.
     >>
     >>prepare XX from UPSERT INTO DE (ID, dataElementConceptID, valueDomainID) 
 
     +>VALUES  (?[10], ?[10], ?[10] ) ;
     
     --- SQL command prepared.
    ->>execute explainIt;
    +>>execute explainItEff;
     
     OPERATOR        
     ----------------
     
    -TRAFODION_MERGE 
    +SEQUENCE        
    --- End diff --
    
    Test cases are nice and robust. I like them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to