Github user sureshsubbiah commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/946#discussion_r99963040
--- Diff: core/sql/executor/ExHbaseIUD.cpp ---
@@ -912,8 +912,22 @@ ExWorkProcRetcode ExHbaseAccessUpsertVsbbSQTcb::work()
copyRowIDToDirectBuffer(rowId_);
currRowNum_++;
- matches_++;
-
+ // temp code below.WIll remove the envvar after this
+ //has got enough exposure in testing.
+ if (getenv("TURN_OFF_RETURNROW"))
--- End diff --
Please consider removing this. From what I can tell from Google, getenv
will have a performance impact, Particularly when called so often (once per
row?). A cqd or COMP_BOOL can be used to tun feature of temporarily. If a
runtime toggle is needed, maybe we call getenv at the top somewhere and store
the value in a local variable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
