Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/946#discussion_r100134813
--- Diff: core/sql/executor/ExHbaseIUD.cpp ---
@@ -1620,21 +1685,20 @@ ExWorkProcRetcode
ExHbaseAccessBulkLoadPrepSQTcb::work()
{
if (qparent_.up->isFull())
return WORK_OK;
-
+
if (returnUpdateExpr())
{
- ex_queue_entry * up_entry = qparent_.up->getTailEntry();
-
- // allocate tupps where returned rows will be created
- if (allocateUpEntryTupps(
- -1,
- 0,
- hbaseAccessTdb().returnedTuppIndex_,
- hbaseAccessTdb().returnUpdatedRowLen_,
- FALSE,
- &rc))
+ ex_queue_entry * up_entry = qparent_.up->getTailEntry();
return rc;
-
+ // allocate tupps where returned rows will be created
+ if (allocateUpEntryTupps(
+ -1,
+ 0,
+ hbaseAccessTdb().returnedTuppIndex_,
+ hbaseAccessTdb().returnUpdatedRowLen_,
+ FALSE,
+ &rc))
+ return 1;
--- End diff --
Should this be return rc?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
