Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1009#discussion_r106023368
--- Diff: core/sql/common/CharType.cpp ---
@@ -752,16 +752,21 @@ NABoolean CharType::isCharSetAndCollationComboOK()
const
// -----------------------------------------------------------------------
// Equality comparison
// -----------------------------------------------------------------------
+NABoolean CharType::compareCharAttrs(const NAType& other) const
+{
--- End diff --
Should this return false if other is not a CharType class? Alternatively,
should the parameter be typed as CharType& instead of NAType&?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
