Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1009#discussion_r106023723
--- Diff: core/sql/common/CharType.cpp ---
@@ -967,6 +972,28 @@ SQLVarChar::SQLVarChar(const CharLenInfo & maxLenInfo,
{}
// -----------------------------------------------------------------------
+// Equality comparison
+// -----------------------------------------------------------------------
+NABoolean SQLVarChar::operator==(const NAType& other) const
+{
+ NABoolean compResult = FALSE; // false, failed. true, passed.
+
+ // if this or other was originally a hive string type, then
+ // do not compare lengths.
+ if ((wasHiveString()) ||
+ ((other.getTypeName() == LiteralVARCHAR) &&
+ (((SQLVarChar&)other).wasHiveString())))
--- End diff --
Is it known that other is SqlVarChar type if other.getTypeName() returns
LiteralVARCHAR? (What happens for national varchar, for example?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
