Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1009#discussion_r106026130
--- Diff: core/sql/generator/GenRelGrby.cpp ---
@@ -105,9 +105,13 @@ short GroupByAgg::genAggrGrbyExpr(Generator *
generator,
ValueId valId;
// find the number of aggregate and groupby entries
- ULng32 numAttrs
- = ((NOT aggregateExpr.isEmpty() ) ? aggregateExpr.entries() : 0)
- + ((NOT groupExpr.isEmpty() ) ? groupExpr.entries() : 0);
+ ULng32 numAttrs = 0;
+ if (NOT aggregateExpr.isEmpty())
+ numAttrs += aggregateExpr.entries();
+ if (isRollup() && (NOT rollupGroupExprList.isEmpty()))
+ numAttrs += rollupGroupExprList.entries();
+ else if (NOT groupExpr.isEmpty())
--- End diff --
I take it that we cannot stick a GROUP BY clause after a ROLLUP?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
