Github user DaveBirdsall commented on a diff in the pull request:

    
https://github.com/apache/incubator-trafodion/pull/1277#discussion_r147222686
  
    --- Diff: core/sql/common/charinfo.h ---
    @@ -260,11 +260,14 @@ class CharInfo
                                              Int32   sourceLenInBytes,
                                              CharSet targetCS);
     
    +  static void initBuiltinCollationDB();
    + 
    +
     private:
     friend class CollationDB;                  // needs to access builtinCDB_
     
        static const char*      const localeCharSet_;
    -   static const CollationDB   builtinCollationDB_;
    +   static const CollationDB   *builtinCollationDB_;
    --- End diff --
    
    Suggest initializing to NULL. So if you get a thread race condition, you'll 
get better behavior if one thread accessing this pointer beats the other thread 
that is initializing it.


---

Reply via email to