Github user selvaganesang commented on a diff in the pull request:

    
https://github.com/apache/incubator-trafodion/pull/1277#discussion_r147250690
  
    --- Diff: core/sql/common/charinfo.cpp ---
    @@ -529,8 +530,10 @@ static const CollationInfo mapCOArray[] = {
       CollationInfo(NULL, CharInfo::UNKNOWN_COLLATION,  
SQLCOLLATIONSTRING_UNKNOWN,
                        STATIC_NEG)
     };
    -static const size_t SIZEOF_CO = sizeof(mapCOArray)/sizeof(CollationInfo);
    -const CollationDB CharInfo::builtinCollationDB_(NULL, mapCOArray, 
SIZEOF_CO);
    +
    +#define SIZEOF_CO (sizeof(mapCOArray)/sizeof(CollationInfo))
    +
    +const CollationDB *CharInfo::builtinCollationDB_;
    --- End diff --
    
    It is required in the rework and it is initialized to NULL


---

Reply via email to