Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1277#discussion_r147223503
--- Diff: core/sql/common/charinfo.cpp ---
@@ -363,21 +363,22 @@ void CollationInfo::display() const
CollationDB::CollationDB(CollHeap *h)
: CollationDBSupertype(h), heap_(h), refreshNeeded_(TRUE)
{
- if (this == &CharInfo::builtinCollationDB_) return;
+ if (this == CharInfo::builtinCollationDB_) return;
--- End diff --
I'm confused. Is CollationDB a singleton object? Or is there one global
version, and other parts of the code might create their own version?
---
