zhangyu-duck commented on code in PR #21504:
URL: https://github.com/apache/nuttx/pull/21504#discussion_r4490553324


##########
arch/tricore/src/common/tricore_irq.c:
##########
@@ -74,26 +79,42 @@ static inline void tricore_color_intstack(void)
  * Private Data
  ****************************************************************************/
 
-static const IfxSrc_Tos g_tricore_tos[] =
-{
-  IfxSrc_Tos_cpu0,
-  IfxSrc_Tos_cpu1,

Review Comment:
   why remove it, tc3 tos is not equal to cpu



##########
arch/tricore/src/common/tricore_doirq.c:
##########
@@ -41,23 +41,42 @@
 
 #include "tricore_internal.h"
 
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+/* The interrupt vector enters tricore_doirq with jli, return with ji */
+
+#ifdef CONFIG_TRICORE_TOOLCHAIN_TASKING
+#  define tricore_irq_return() __asm__ volatile ("ji a11" : : : "a11")

Review Comment:
   repeat with svcall.c, can we define tricore_jump_backto_link and move to 
arch.h



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to