Copilot commented on code in PR #2463: URL: https://github.com/apache/age/pull/2463#discussion_r3531241592
########## RELEASE: ########## @@ -15,44 +15,95 @@ # specific language governing permissions and limitations # under the License. -Release Notes for Apache AGE release 1.7.0 for master branch (currently PG18) +Release Notes for Apache AGE release 1.8.0 for PG19 branch (currently PG19beta1) # # WARNING! # -# Please note the upgrade script (age--1.6.0--1.7.0.sql) may take a while to -# complete for large graphs, due to creation of indexes for existing labels. +# Always back up your database before executing any upgrade scripts +# +# This is a BETA release of Apache AGE built on PostgreSQL 19beta1. Please, +# treat is as such! Review Comment: Typo in the beta disclaimer: "treat is as such" should be "treat it as such". ########## docker/Dockerfile: ########## @@ -52,7 +52,7 @@ ENV LC_COLLATE=en_US.UTF-8 ENV LC_CTYPE=en_US.UTF-8 COPY --from=build /usr/lib/postgresql/19/lib/age.so /usr/lib/postgresql/19/lib/ -COPY --from=build /usr/share/postgresql/19/extension/age--1.7.0.sql /usr/share/postgresql/19/extension/ +COPY --from=build /usr/share/postgresql/19/extension/age--1.8.0.sql /usr/share/postgresql/19/extension/ COPY --from=build /usr/share/postgresql/19/extension/age.control /usr/share/postgresql/19/extension/ Review Comment: The final image only copies the generated install script (age--1.8.0.sql) but not the upgrade scripts (e.g., age--1.6.0--1.7.0.sql, age--1.7.0--1.8.0.sql). This breaks `ALTER EXTENSION age UPDATE ...` for users upgrading an existing data volume inside the container. ########## age--1.8.0--y.y.y.sql: ########## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +-- This will only work within a major version of PostgreSQL, not across +-- major versions. + +--* This is a TEMPLATE for upgrading from the previous version of Apache AGE +--* Please adjust the below ALTER EXTENSION to reflect the -- correct version it +--* is upgrading to. Review Comment: The template line has an extra "--" mid-sentence ("reflect the -- correct"), which reads like a comment break and makes the instructions unclear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
