Copilot commented on code in PR #2463: URL: https://github.com/apache/age/pull/2463#discussion_r3532105125
########## docker/Dockerfile: ########## @@ -52,7 +52,7 @@ ENV LC_COLLATE=en_US.UTF-8 ENV LC_CTYPE=en_US.UTF-8 COPY --from=build /usr/lib/postgresql/19/lib/age.so /usr/lib/postgresql/19/lib/ -COPY --from=build /usr/share/postgresql/19/extension/age--1.7.0.sql /usr/share/postgresql/19/extension/ +COPY --from=build /usr/share/postgresql/19/extension/age--1.8.0.sql /usr/share/postgresql/19/extension/ COPY --from=build /usr/share/postgresql/19/extension/age.control /usr/share/postgresql/19/extension/ Review Comment: The final Docker image copies only the generated install SQL (age--1.8.0.sql) but not the shipped upgrade scripts (e.g., age--1.6.0--1.7.0.sql, age--1.7.0--1.8.0.sql). This prevents `ALTER EXTENSION age UPDATE ...` from working when users upgrade an existing data directory inside the container. ########## age--1.8.0--y.y.y.sql: ########## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +-- This will only work within a major version of PostgreSQL, not across +-- major versions. + +--* This is a TEMPLATE for upgrading from the previous version of Apache AGE +--* Please adjust the below ALTER EXTENSION to reflect the correct version it +--* is upgrading to. + +-- This will only work within a major version of PostgreSQL, not across +-- major versions. Review Comment: These two lines duplicate the major-version warning that already appears a few lines above, making the upgrade template noisier than necessary. ########## README.md: ########## @@ -125,7 +125,7 @@ Apache AGE is intended to be simple to install and run. It can be installed with Install PostgreSQL </h4> -You will need to install an AGE compatible version of Postgres<a>, for now AGE supports Postgres 11, 12, 13, 14, 15, 16, 17 & 18. Supporting the latest versions is on AGE roadmap. +You will need to install an AGE compatible version of Postgres<a>, for now AGE supports Postgres 11, 12, 13, 14, 15, 16, 17, 18, 19beta1. Supporting the latest versions is on AGE roadmap. Review Comment: This line contains a stray `<a>` tag ("Postgres<a>") which produces invalid HTML in the rendered README. ########## META.json: ########## @@ -2,23 +2,23 @@ "name": "ApacheAGE", "abstract": "Apache AGE is a PostgreSQL Extension that provides graph database functionality", "description": "Apache AGE is a PostgreSQL Extension that provides graph database functionality. AGE is an acronym for A Graph Extension, and is inspired by Bitnine's fork of PostgreSQL 10, AgensGraph, which is a multi-model database. The goal of the project is to create single storage that can handle both relational and graph model data so that users can use standard ANSI SQL along with openCypher, the Graph query language. A graph consists of a set of vertices (also called nodes) and edges, where each individual vertex and edge possesses a map of properties. A vertex is the basic object of a graph, that can exist independently of everything else in the graph. An edge creates a directed connection between two vertices. A graph database is simply composed of vertices and edges. This type of database is useful when the meaning is in the relationships between the data. Relational databases can easily handle direct relationships, but indirect relationships are more difficult to deal with in relational databases. A graph database stores relationship information as a first-class entity. Apache AGE gives you the best of both worlds, simultaneously.", - "version": "1.3.0", + "version": "1.8.0", "maintainer": [ "[email protected]" ], "license": "apache_2_0", "provides": { "ApacheAGE": { "abstract": "Apache AGE is a PostgreSQL Extension that provides graph database functionality", - "file": "age--1.3.0.sql", + "file": "age--1.8.0.sql", "docfile": "README.md", - "version": "1.3.0" + "version": "1.8.0" } }, "prereqs": { "runtime": { "requires": { - "PostgreSQL": "14.0.0" + "PostgreSQL": "19.0.0" } Review Comment: PR description and other docs call out PostgreSQL 19beta1, but META.json declares a runtime prerequisite of PostgreSQL 19.0.0. If this metadata is used for packaging/validation, it may incorrectly reject PG19beta1 or otherwise misrepresent the supported server version(s). Please align META.json with the intended support policy for this branch (beta vs GA, and whether older PG majors are supported). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
