jrgemignani commented on PR #2463:
URL: https://github.com/apache/age/pull/2463#issuecomment-4898037484
From Opus 4.8 Max 1M -
## PR #2463 review — Advance PG19 branch to Apache AGE 1.8.0
**Verdict: Complete and correct — LGTM to merge.** It faithfully mirrors the
master
1.8.0 advance (#2455) for the PG19 branch and additionally bundles the
driver-image
fix. Built and tested against PostgreSQL 19beta1; two minor, non-blocking
notes below.
### Completeness — all version surfaces bumped
| File | Change |
|---|---|
| `age.control` | `default_version` → **1.8.0** |
| `META.json` | version → 1.8.0, `file` → `age--1.8.0.sql`, `PostgreSQL` →
**19.0.0** |
| `README.md` | badge v1.7.0→v1.8.0, PG18→PG19 doc links, supported list
adds `19beta1` |
| `RELEASE` | 1.8.0 notes for the PG19 branch (PG19beta1) + BETA warning |
| `age--1.7.0--y.y.y.sql` → `age--1.7.0--1.8.0.sql` | renamed; template
lines removed; echo → `'1.8.0'` |
| `age--1.8.0--y.y.y.sql` | new next-version template |
| `docker/Dockerfile` | COPY `age--1.7.0.sql` → `age--1.8.0.sql` |
| `drivers/{docker-compose.yml, jdbc, nodejs}` | `dev_snapshot_master` →
`dev_snapshot_PG19` |
### Correctness — verified empirically on PG19beta1
- Clean `COPT=-Werror` build (0 warnings); Makefile **generates
`age--1.8.0.sql`**, so
`CREATE EXTENSION` resolves at the new default.
- Fresh install reports **1.8.0** and a cypher `CREATE` works.
- **`age_upgrade` regression passes — All 43 tests passed** (the
authoritative 1.7.0→1.8.0
check; it synthesizes the real 1.7.0 from git history and applies the
upgrade).
- The `age--1.7.0--1.8.0.sql` DDL is **byte-identical to master's**
already-validated script.
### Non-blocking notes
1. **(Pre-existing, not introduced here)** The pg_upgrade support functions
live in *both*
the `sql/` source (→ generated default install) and the
`age--1.7.0--1.8.0.sql` upgrade
script. This is safe for real upgrades (the 1.7.0 release predates those
functions, so
the upgrade script adds them cleanly — confirmed by `age_upgrade`). The
only way to trip
a `"function ... already exists"` error is if a stale, generated
`age--1.7.0.sql` lingers
in the extension dir and someone does `CREATE EXTENSION age VERSION
'1.7.0'` then upgrades.
A clean 1.8.0 build ships only `age--1.8.0.sql` + upgrade scripts, so
packaged installs
are unaffected. Worth tracking as a latent footgun; out of scope for this
PR.
2. **Cosmetic:** `age--1.8.0--y.y.y.sql` carries a duplicated `-- This will
only work within
a major version…` comment (a stray block above the `--*` header). It's
identical on
master's template, so this PR correctly mirrors master — worth a one-line
cleanup on both
branches eventually, harmless as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
